Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semconvgen.yml workflow to run on feature/* branches #256

Conversation

arminru
Copy link
Member

@arminru arminru commented Jan 9, 2024

This should allow @lmolkova's changes from #243 to be published under a specific tag on Docker Hub.

cc @open-telemetry/specs-semconv-maintainers

@arminru arminru requested review from lmolkova and a team January 9, 2024 12:04
@arminru arminru requested a review from a team January 12, 2024 15:56
@Oberon00
Copy link
Member

Oberon00 commented Jan 22, 2024

feature/ is a common prefix for a PR branch, should we not use a different prefix, like prerelease/ or something?

@arminru
Copy link
Member Author

arminru commented Feb 1, 2024

@Oberon00 that's the intent actually - we'd only have new features which we'd want to offer as a pre-release in such branches in this repo here. Any personal feature/ branch coming in from a fork (towards main or feature/ in here) should not be picked up by this workflow.

@jack-berg
Copy link
Member

Hi - left a comment on #243 but figured I'd leave one here for more visibility.

The java SIG is looking to use the features of #243 in this PR. Couple of questions:

  • Is there a timetable for publishing a docker image for the feature branch?
  • Once a docker image is available, is it safe to use it to publish generated code using it? Not looking to publish stable artifacts, but essentially hoping that the new features of Support codegen by namespace #243 aren't going to go away. 🙂

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arminru arminru merged commit fa298d7 into open-telemetry:feature/codegen-by-namespace Feb 12, 2024
3 checks passed
@arminru arminru deleted the semconvgen-push-features branch February 12, 2024 17:19
@arminru
Copy link
Member Author

arminru commented Feb 12, 2024

@jack-berg

Is there a timetable for publishing a docker image for the feature branch?

We were only waiting for this PR to merged and it looks like it worked 🙂

https://hub.docker.com/r/otel/semconvgen/tags --> otel/semconvgen:feature-codegen-by-namespace

Once a docker image is available, is it safe to use it to publish generated code using it? Not looking to publish stable artifacts, but essentially hoping that the new features of #243 aren't going to go away. 🙂

You should be fine pointing at :feature-codegen-by-namespace for now but at some point we will want to merge this to main and then we'd also remove the feature branch and image.
This would then likely break your build in Java semconv but it should be a quick fix pointing it back at :latest.

@jack-berg
Copy link
Member

Thanks so much!

lmolkova pushed a commit to lmolkova/build-tools that referenced this pull request Feb 29, 2024
lmolkova pushed a commit to lmolkova/build-tools that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants