Skip to content

Commit

Permalink
fix checks target
Browse files Browse the repository at this point in the history
  • Loading branch information
hughesjj committed Nov 12, 2024
1 parent 4b322db commit dd25bb9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 15 deletions.
15 changes: 2 additions & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,19 +203,8 @@ When submitting a component to the community, consider breaking it down into sep
* This PR is usually trivial to review, so the size limit does not apply to
it.
* The component should use [`In Development` Stability](https://github.com/open-telemetry/opentelemetry-collector#development) in its README.
* Before submitting a PR, run the following commands from the root of the repository to ensure your new component is meeting the repo linting expectations:
* `make checkdoc`
* `make checkmetadata`
* `make checkapi`
* `make goporto`
* `make crosslink`
* `make gotidy`
* `make genotelcontribcol`
* `make genoteltestbedcol`
* `make generate`
* `make multimod-verify`
* `make generate-gh-issue-templates`
* `make addlicense`
* As always, ensure you generate a changelog template (refer to [Adding a Changelog Entry](#adding-a-changelog-entry)).
* Before submitting a PR, run `make checks` from the root of the repository to ensure your new component is meeting the repo linting expectations.
* **Second PR** should include the concrete implementation of the component. If the
size of this PR is larger than the recommended size consider splitting it in
multiple PRs.
Expand Down
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -561,14 +561,16 @@ generate-gh-issue-templates:

.PHONY: checks
checks:
$(MAKE) gomoddownload
$(MAKE) install-tools
$(MAKE) genotelcontribcol
$(MAKE) genoteltestbedcol
$(MAKE) checkdoc
$(MAKE) checkmetadata
$(MAKE) checkapi
$(MAKE) -j4 goporto
$(MAKE) crosslink
$(MAKE) -j4 gotidy
$(MAKE) genotelcontribcol
$(MAKE) genoteltestbedcol
$(MAKE) gendistributions
$(MAKE) -j4 generate
$(MAKE) multimod-verify
Expand Down

0 comments on commit dd25bb9

Please sign in to comment.