-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/kafka] Add factory options for custom metric and log marshalers #16540
[exporter/kafka] Add factory options for custom metric and log marshalers #16540
Conversation
@MovieStoreGuy Sorry for creating a new PR. This should have all your recommendations incorporated. It also leverages your latest factory_test approach. |
… exporter-output-based
@MovieStoreGuy It was a bit more involved than initially thought. I've removed the log-based assertion of the expected marshaler being selected and replaced with an approach that validates the marshaler by assessing the exporter output.
|
…tions have been satisfied
Let me have a further look to see how i can help :) |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Once you get a chance @bgranetzke , please rebase :) |
@MovieStoreGuy Thank you for the changes. Correct me if I've missed something, but there is no longer a reason for this PR, correct? Just checking before I close it. Thanks again! |
I don't believe so @bgranetzke , you should be safe to close this out. |
Description:
Adding ExportFactory options to add custom log/metric marshalers (similar to existing: WithTracesMarshalers)
Link to tracking Issue: #14514
Testing:
Tests were added for the new options as well as adapting the previous test for WithTracesMarshalers to the new method.