Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/pprof] Improve documentation for pprof usage #28665

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

Jamie-Ullerich
Copy link
Contributor

Description: Update readme with instructions on how to use pprof

Link to tracking Issue: #26095

Testing: Not applicable since no functional code was changed.

Documentation: The extension readme now contains information what a profile is, how it can be generated and analysed.

@Jamie-Ullerich Jamie-Ullerich requested a review from a team October 27, 2023 14:08
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA

@songy23 songy23 added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 27, 2023
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, otherwise LGTM

After running the above command to save the profile, _pprof_ will enter the interactive mode.
From here, the profiles can be analyzed.

Use the command `web` to open an image of the complete call graph in your browser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to also mention Graphviz as a prerequisite for web

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 16, 2023
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Nov 16, 2023
@github-actions github-actions bot removed the Stale label Nov 17, 2023
@TylerHelmuth TylerHelmuth merged commit 399a74b into open-telemetry:main Nov 20, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 20, 2023
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…ry#28665)

**Description:** Update readme with instructions on how to use pprof

**Link to tracking Issue:**
open-telemetry#26095

**Testing:** Not applicable since no functional code was changed.

**Documentation:** The extension readme now contains information what a
profile is, how it can be generated and analysed.

Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation extension/pprof ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants