-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/pprof] Improve documentation for pprof usage #28665
[extension/pprof] Improve documentation for pprof usage #28665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion, otherwise LGTM
After running the above command to save the profile, _pprof_ will enter the interactive mode. | ||
From here, the profiles can be analyzed. | ||
|
||
Use the command `web` to open an image of the complete call graph in your browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to also mention Graphviz as a prerequisite for web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…ry#28665) **Description:** Update readme with instructions on how to use pprof **Link to tracking Issue:** open-telemetry#26095 **Testing:** Not applicable since no functional code was changed. **Documentation:** The extension readme now contains information what a profile is, how it can be generated and analysed. Co-authored-by: Tyler Helmuth <[email protected]>
Description: Update readme with instructions on how to use pprof
Link to tracking Issue: #26095
Testing: Not applicable since no functional code was changed.
Documentation: The extension readme now contains information what a profile is, how it can be generated and analysed.