[pkg/kafka] move internal/kafka to pkg/kafka

[vincentfree]

Description:

Move internal/kafka to pkg/kafka so that the Authorization configuration can be exported for downstream use.

Link to tracking Issue:
#30377

Testing:
Ensured that all modules which have been touched are still working. Since no extra code has been introduced, no extra tests need to be included.

Documentation:

This was mainly a move of files, no new functionality or documentation

[vincentfree]

@dmitryax as promised :)
I have validated that it works for all involved modules but the code coverage failed on my branch probably due to missing configuration for the CI configuration, I expect everything is in order for this PR

[atoulme]

Please resolve conflicts.

[dmitryax]

LGTM. Thanks! Please rebase

[bogdandrutu]

Why exposing all the internal package when only config is needed. There are lots of public types in this package which I am not sure we want to expose publicly if only the config is needed per the issue.

[dmitryax]

Why exposing all the internal package when only config is needed. There are lots of public types in this package which I am not sure we want to expose publicly if only the config is needed per the issue.

Right. That was the original ask actually. I see IAMSASLClient XDGSCRAMClient unnecessary exposed along with ConfigureAuthentication. @vincentfree can you please keep them in the internal module?

[vincentfree]

Why exposing all the internal package when only config is needed. There are lots of public types in this package which I am not sure we want to expose publicly if only the config is needed per the issue.

Right. That was the original ask actually. I see IAMSASLClient XDGSCRAMClient unnecessary exposed along with ConfigureAuthentication. @vincentfree can you please keep them in the internal module?

Yea I can move them back

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.