[receiver/httpcheck] refactor client length checking #31036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Feb 5, 2024
| @@ -46,12 +46,13 @@ func (h *httpcheckScraper) start(_ context.Context, host component.Host) (err er | |||
|
|
|||
| // scrape connects to the endpoint and produces metrics based on the response | |||
| func (h *httpcheckScraper) scrape(ctx context.Context) (pmetric.Metrics, error) { | |||
| if h.clients == nil || len(h.clients) == 0 { | |||
There was a problem hiding this comment.
Is there a case where this change catches something that didn't used to be caught? If clients is nil, it returns the error, if the length is 0, it returns the error.
There was a problem hiding this comment.
No, it's the same logic. The new change is to remove redundant checking. If a slice is nil then its length is also zero
tranngoclam
force-pushed
the
refactor/httpcheckreceiver-scraper
branch
from
9adf6ed to
aaf8e9e
Compare
|
@codeboten can you review the PR again? Thanks |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
clentErr) in receiver/httpcheckreceiver.Link to tracking Issue:
Testing:
Documentation: