[chore] update codeowners to match metadata.yaml content #31043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Feb 5, 2024
crobert-1
reviewed
Feb 5, 2024
| @@ -28,7 +28,7 @@ confmap/provider/s3provider/ @open-telemetry/collect | |||
| connector/countconnector/ @open-telemetry/collector-contrib-approvers @djaglowski @jpkrohling | |||
| connector/datadogconnector/ @open-telemetry/collector-contrib-approvers @mx-psi @dineshg13 | |||
| connector/exceptionsconnector/ @open-telemetry/collector-contrib-approvers @jpkrohling @marctc | |||
| connector/failoverconnector/ @open-telemetry/collector-contrib-approvers @akats7 @djaglowski @fatsheep9146 | |||
There was a problem hiding this comment.
@akats7 is the contributor of this component, maybe we should add them properly as code owner instead of removing here?
There was a problem hiding this comment.
This is reflecting what is in metadata.yaml. 172889d doesn't list them in codeowners, worth a separate issue to follow up.
There was a problem hiding this comment.
That's fair. @akats7 can you open a PR adding yourself as code owner to this component?
There was a problem hiding this comment.
Thanks @crobert-1, yep will do
atoulme
force-pushed
the
update_codeowners_remotetap
branch
from
5d8edcf to
d8963b2
Compare
pmcollins
approved these changes
Feb 5, 2024
dmitryax
approved these changes
Feb 5, 2024
codeboten
pushed a commit
that referenced
this pull request
Feb 5, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This removes @pmcollins as code owner, as he reached out and is no longer able to be a code owner in the collector repository. Thanks for all of your help here Pablo! **Link to tracking Issue:** <Issue number if applicable> Should be merged after #31043.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update codeowners against the latest info from the opentelemetry membership list.
Update remotetap processor codeowners, removing @pmcollins and adding @atoulme