Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][connector/routing] Consolidate test input into one file #36129

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[chore][connector/routing] Consolidate test input into one file #36129

merged 1 commit into from
Nov 1, 2024

Conversation

djaglowski
Copy link
Member

This PR picks up a couple improvements to the test framework from #36097.

  • Use the same input file for all tests. Initially I wasn't sure this one example would be sufficient for all test cases, but now that logs routing has been fully implemented, I'm comfortable consolidating.
  • Condense loading and validation of optional "expected" files.

@github-actions github-actions bot requested review from jpkrohling and mwear November 1, 2024 13:36
@djaglowski djaglowski marked this pull request as ready for review November 1, 2024 14:05
@djaglowski djaglowski requested a review from a team as a code owner November 1, 2024 14:05
@djaglowski djaglowski merged commit 122acb6 into open-telemetry:main Nov 1, 2024
161 checks passed
@djaglowski djaglowski deleted the routing-tests-logs-cleanup branch November 1, 2024 22:08
@github-actions github-actions bot added this to the next release milestone Nov 1, 2024
ArthurSens pushed a commit to ArthurSens/opentelemetry-collector-contrib that referenced this pull request Nov 4, 2024
@djaglowski @ArthurSens
[chore][connector/routing] Consolidate test input into one file (open…
64fe19a 
…-telemetry#36129)
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@djaglowski @sbylica-splunk
[chore][connector/routing] Consolidate test input into one file (open…
7060dd0 
…-telemetry#36129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

Assignees

@bogdandrutu bogdandrutu

Labels
connector/routing
Projects
None yet
Milestone
v0.113.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djaglowski @mwear @bogdandrutu