[receiver/k8scluster] Fix e2e tests by limiting jobs/pods of cronjob to 1 #36235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
requested review from
dmitryax,
TylerHelmuth and
a team
as code owners
povilasv
approved these changes
Nov 6, 2024
…f cronjob to 1 Signed-off-by: ChrsMark <[email protected]>
bacherfl
approved these changes
Nov 6, 2024
atoulme
approved these changes
Nov 6, 2024
jvoravong
approved these changes
Nov 6, 2024
TylerHelmuth
approved these changes
Nov 7, 2024
pull bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this pull request
Nov 7, 2024
…to 1 (open-telemetry#36235) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes what was described at open-telemetry#35727 (comment). After open-telemetry#36114 the `k8scluster` receiver's e2e tests started showing some flakiness ([example](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11701936581/job/32589392145)). With this change we ensure that only 1 active job/pod of the cronjob will be present for the whole lifetime of the test to avoid hitting timing/scheduling related flakiness. @bacherfl could you also take a look here? <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: ChrsMark <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…to 1 (open-telemetry#36235) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes what was described at open-telemetry#35727 (comment). After open-telemetry#36114 the `k8scluster` receiver's e2e tests started showing some flakiness ([example](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11701936581/job/32589392145)). With this change we ensure that only 1 active job/pod of the cronjob will be present for the whole lifetime of the test to avoid hitting timing/scheduling related flakiness. @bacherfl could you also take a look here? <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: ChrsMark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes what was described at #35727 (comment).
After #36114 the
k8sclusterreceiver's e2e tests started showing some flakiness (example).With this change we ensure that only 1 active job/pod of the cronjob will be present for the whole lifetime of the test to avoid hitting timing/scheduling related flakiness.
@bacherfl could you also take a look here?
Link to tracking issue
Fixes
Testing
Documentation