Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix opampsupervisor test on Windows #36282

Merged

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Nov 8, 2024

Fix #36278

The issue is that the temporary path used in the test is passed as text to an yaml file so the Windows dir separator ends up as a escape char on the yaml.

@pjanotti pjanotti added the Run Windows Enable running windows test on a PR label Nov 8, 2024
@pjanotti pjanotti added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 8, 2024
@dmitryax dmitryax merged commit 5618c7c into open-telemetry:main Nov 8, 2024
198 of 211 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 8, 2024
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this pull request Nov 9, 2024
Fix open-telemetry#36278

The issue is that the temporary path used in the test is passed as text
to an yaml file so the Windows dir separator ends up as a escape char on
the yaml.
@pjanotti pjanotti deleted the fix-opampsupervisor-test-on-windows branch November 10, 2024 01:17
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Fix open-telemetry#36278

The issue is that the temporary path used in the test is passed as text
to an yaml file so the Windows dir separator ends up as a escape char on
the yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] [cmd/opampsupervisor] TestSupervisorRemoteConfigApplyStatus flaky
4 participants