Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix checks target #36342

Closed
wants to merge 4 commits into from
Closed

[chore] fix checks target #36342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1218990
fix checks target
hughesjj Nov 12, 2024
8655738
Merge branch 'main' into devsetup
dmitryax Nov 29, 2024
4b69ee1
Merge branch 'main' into devsetup
hughesjj Dec 2, 2024
c4a0ee8
Merge branch 'main' into devsetup
dmitryax Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,19 +203,8 @@ When submitting a component to the community, consider breaking it down into sep
* This PR is usually trivial to review, so the size limit does not apply to
it.
* The component should use [`In Development` Stability](https://github.com/open-telemetry/opentelemetry-collector#development) in its README.
* Before submitting a PR, run the following commands from the root of the repository to ensure your new component is meeting the repo linting expectations:
* `make checkdoc`
* `make checkmetadata`
* `make checkapi`
* `make goporto`
* `make crosslink`
* `make gotidy`
* `make genotelcontribcol`
* `make genoteltestbedcol`
* `make generate`
* `make multimod-verify`
* `make generate-gh-issue-templates`
* `make addlicense`
* As always, ensure you generate a changelog template (refer to [Adding a Changelog Entry](#adding-a-changelog-entry)).
* Before submitting a PR, run `make checks` from the root of the repository to ensure your new component is meeting the repo linting expectations.
* **Second PR** should include the concrete implementation of the component. If the
size of this PR is larger than the recommended size consider splitting it in
multiple PRs.
Expand Down
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,14 +560,16 @@ generate-gh-issue-templates:

.PHONY: checks
checks:
$(MAKE) gomoddownload
$(MAKE) install-tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one cannot be cached and can add significant amount to time to each run. Not sure it should be added here

$(MAKE) genotelcontribcol
$(MAKE) genoteltestbedcol
$(MAKE) checkdoc
$(MAKE) checkmetadata
$(MAKE) checkapi
$(MAKE) -j4 goporto
$(MAKE) crosslink
$(MAKE) -j4 gotidy
$(MAKE) genotelcontribcol
$(MAKE) genoteltestbedcol
$(MAKE) gendistributions
$(MAKE) -j4 generate
$(MAKE) multimod-verify
Expand Down
Loading