Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: use testify instead of testing.Fatal or testing.Error in processor #36374

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[chore]: use testify instead of testing.Fatal or testing.Error in processor #36374

merged 1 commit into from
Dec 4, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

  • uses testify instead of testing.Fatal or testing.Error in processor

@github-actions github-actions bot added processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/deltatocumulative processor/k8sattributes k8s Attributes processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/resourcedetection Resource detection processor processor/tailsampling Tail sampling processor processor/transform Transform processor labels Nov 14, 2024
@mmorel-35 mmorel-35 force-pushed the testifier/processor branch 3 times, most recently from 7b5af45 to 51418ed Compare November 14, 2024 07:17
@mmorel-35 mmorel-35 marked this pull request as draft November 14, 2024 07:40
@mmorel-35 mmorel-35 marked this pull request as ready for review November 14, 2024 08:41
@mmorel-35 mmorel-35 force-pushed the testifier/processor branch 2 times, most recently from a1d207b to 4a6648a Compare November 14, 2024 09:11
@mmorel-35 mmorel-35 force-pushed the testifier/processor branch 6 times, most recently from 3b08021 to 1fbd6a3 Compare November 20, 2024 18:02
@mmorel-35 mmorel-35 force-pushed the testifier/processor branch from d5c5226 to 4e9a583 Compare December 1, 2024 08:13
@TylerHelmuth TylerHelmuth added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Dec 4, 2024
@evan-bradley
Copy link
Contributor

@mmorel-35 Could you resolve the conflict?

@mmorel-35 mmorel-35 force-pushed the testifier/processor branch from 4e9a583 to c0a99af Compare December 4, 2024 17:46
@evan-bradley evan-bradley merged commit ed96f74 into open-telemetry:main Dec 4, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 4, 2024
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
@mmorel-35 @shivanthzen
[chore]: use testify instead of testing.Fatal or testing.Error in pro…
175d7a0 
…cessor (open-telemetry#36374)
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
@mmorel-35 @ZenoCC-Peng
[chore]: use testify instead of testing.Fatal or testing.Error in pro…
04a87fb 
…cessor (open-telemetry#36374)
@mmorel-35 mmorel-35 deleted the testifier/processor branch December 14, 2024 13:56
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@mmorel-35 @sbylica-splunk
[chore]: use testify instead of testing.Fatal or testing.Error in pro…
762c942 
…cessor (open-telemetry#36374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez left review comments

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@evan-bradley evan-bradley evan-bradley approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@dashpole dashpole Awaiting requested review from dashpole

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@boostchicken boostchicken Awaiting requested review from boostchicken

@kentquirk kentquirk Awaiting requested review from kentquirk

@RichieSams RichieSams Awaiting requested review from RichieSams

Assignees

@dashpole dashpole

@songy23 songy23

Labels
processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/deltatocumulative processor/k8sattributes k8s Attributes processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/resourcedetection Resource detection processor processor/tailsampling Tail sampling processor processor/transform Transform processor
Projects
None yet
Milestone
v0.116.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mmorel-35 @evan-bradley @TylerHelmuth @sh0rez @dashpole @songy23