Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix data race on windowseventlogreceiver tests #36406

Conversation

pjanotti
Copy link
Contributor

Fixes a data race detected here. This doesn't solve the flakiness detected on this receiver tests, only avoids the data race.

@pjanotti pjanotti requested a review from a team as a code owner November 17, 2024 17:04
@pjanotti pjanotti requested a review from ChrsMark November 17, 2024 17:04
@github-actions github-actions bot requested a review from armstrmi November 17, 2024 17:05
@pjanotti pjanotti added Run Windows Enable running windows test on a PR and removed receiver/windowseventlog labels Nov 17, 2024
@pjanotti pjanotti added the ready to merge Code review completed; ready to merge by maintainers label Nov 18, 2024
@TylerHelmuth TylerHelmuth merged commit bf5cd1c into open-telemetry:main Nov 18, 2024
181 of 200 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 18, 2024
@pjanotti pjanotti deleted the fix-data-race-on-windowseventlogreceiver-tests branch November 18, 2024 21:59
RutvikS-crest pushed a commit to RutvikS-crest/opentelemetry-collector-contrib that referenced this pull request Dec 9, 2024
…y#36406)

Fixes a data race detected
[here](open-telemetry#34687 (comment)).
This doesn't solve the flakiness detected on this receiver tests, only
avoids the data race.
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…y#36406)

Fixes a data race detected
[here](open-telemetry#34687 (comment)).
This doesn't solve the flakiness detected on this receiver tests, only
avoids the data race.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/windowseventlog Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants