[chore] enable gofumpt globally #36471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mmorel-35
force-pushed
the
gofumpt
branch
3 times, most recently
from
7da7d1a to
f4296b3
Compare
github-actions
bot
added
cmd/githubgen
cmd/opampsupervisor
cmd/telemetrygen
mmorel-35
force-pushed
the
gofumpt
branch
2 times, most recently
from
9f6229a to
f17fa44
Compare
mmorel-35
requested review from
dashpole,
a team,
jmacd,
dmitryax,
TylerHelmuth,
atoulme,
mx-psi,
codeboten,
evan-bradley and
tigrannajaryan
as code owners
|
/cc @andrzej-stencel |
songy23
approved these changes
Nov 21, 2024
andrzej-stencel
approved these changes
Nov 21, 2024
dmitryax
approved these changes
Nov 21, 2024
MovieStoreGuy
pushed a commit
that referenced
this pull request
Dec 11, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description As we change the gofmt by gofumpt -> #36471, the rewrite rule that is responsible for change `interface{}` by `any` isn't working anymore. We noticed this problem here -> #36688 (comment). This PR tries to address this lack.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description [gofumpt](https://golangci-lint.run/usage/linters/#gofumpt) enforces a stricter format than gofmt Closes open-telemetry#36363
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description As we change the gofmt by gofumpt -> open-telemetry#36471, the rewrite rule that is responsible for change `interface{}` by `any` isn't working anymore. We noticed this problem here -> open-telemetry#36688 (comment). This PR tries to address this lack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gofumpt enforces a stricter format than gofmt
Closes #36363