[exporter/datadog] add basic API key validation on startup #36510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
jade-guiton-dd,
liustanley,
mackjmr,
mx-psi and
songy23
|
going to look into this, not clear immediately if it's just broken/outdated test or if my change broke the intended behavior |
|
there may still be a discussion to be had around if we need to improve our API Key validation logic, but this keeps the behavior of v0.110.0 and prior so as to not break existing customers |
mx-psi
requested changes
Nov 26, 2024
There was a problem hiding this comment.
This error comes from changes in the confmap and it is intentional. You can see the "0123" row in https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/env-vars.md#comparison-table-with-current-behavior that is this very case. I think we should not do this change and just think about how to improve the user experience (I left a concrete suggestion below).
jackgopack4
changed the title
jackgopack4
commented
Nov 27, 2024
mx-psi
reviewed
Dec 2, 2024
mx-psi
approved these changes
Dec 3, 2024
|
@mx-psi fixed merged conflicts and failing tests, should be good to go |
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…metry#36510) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description adds basic hexadecimal character validation to Datadog API key on startup <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36509 <!--Describe what testing was performed and which tests were added.--> #### Testing new "invalid API Key" test <!--Describe the documentation added.--> #### Documentation changelog file <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Pablo Baeyens <[email protected]>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…metry#36510) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description adds basic hexadecimal character validation to Datadog API key on startup <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36509 <!--Describe what testing was performed and which tests were added.--> #### Testing new "invalid API Key" test <!--Describe the documentation added.--> #### Documentation changelog file <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Pablo Baeyens <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…metry#36510) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description adds basic hexadecimal character validation to Datadog API key on startup <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36509 <!--Describe what testing was performed and which tests were added.--> #### Testing new "invalid API Key" test <!--Describe the documentation added.--> #### Documentation changelog file <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds basic hexadecimal character validation to Datadog API key on startup
Link to tracking issue
Fixes #36509
Testing
new "invalid API Key" test
Documentation
changelog file