-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][testbed] add filelog as a part of test cases #36603
Merged
djaglowski
merged 8 commits into
open-telemetry:main
from
VihasMakwana:expand-to-filelog
Dec 18, 2024
Merged
[chore][testbed] add filelog as a part of test cases #36603
djaglowski
merged 8 commits into
open-telemetry:main
from
VihasMakwana:expand-to-filelog
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
changed the title
[chore[testbed] add filelog as a part of test cases
[chore][testbed] add filelog as a part of test cases
Nov 29, 2024
VihasMakwana
added
the
Skip Changelog
PRs that do not require a CHANGELOG.md entry
label
Dec 2, 2024
ChrsMark
reviewed
Dec 10, 2024
VihasMakwana
force-pushed
the
expand-to-filelog
branch
from
December 16, 2024 14:08
d443052
to
d2b22c2
Compare
@ChrsMark can you please take at this PR? I've used options. |
ChrsMark
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Co-authored-by: Christos Markou <[email protected]>
ChrsMark
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @djaglowski as more familiar with filelog receiver.
djaglowski
approved these changes
Dec 18, 2024
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
…36603) Recently, we added memory limiter test cases for OTLP. This PR updates the cases to work with filelog sender as well. --------- Co-authored-by: Christos Markou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we added memory limiter test cases for OTLP.
This PR updates the cases to work with filelog sender as well.