Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][testbed] add filelog as a part of test cases #36603

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

VihasMakwana
Copy link
Contributor

Recently, we added memory limiter test cases for OTLP.
This PR updates the cases to work with filelog sender as well.

@VihasMakwana VihasMakwana requested a review from a team as a code owner November 29, 2024 16:26
@VihasMakwana VihasMakwana changed the title [chore[testbed] add filelog as a part of test cases [chore][testbed] add filelog as a part of test cases Nov 29, 2024
@VihasMakwana VihasMakwana added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 2, 2024
@VihasMakwana
Copy link
Contributor Author

@ChrsMark can you please take at this PR? I've used options.

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

testbed/tests/scenarios.go Outdated Show resolved Hide resolved
testbed/tests/scenarios.go Show resolved Hide resolved
Co-authored-by: Christos Markou <[email protected]>
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pinging @djaglowski as more familiar with filelog receiver.

@djaglowski djaglowski merged commit 8959710 into open-telemetry:main Dec 18, 2024
161 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 18, 2024
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this pull request Dec 19, 2024
…36603)

Recently, we added memory limiter test cases for OTLP. 
This PR updates the cases to work with filelog sender as well.

---------

Co-authored-by: Christos Markou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry testbed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants