[pkg/ottl]Add trace_state.adjusted_count path to span context #36789
Conversation
github-actions
bot
added
connector/count
connector/datadog
connector/routing
connector/sum
exporter/datadog
github-actions
bot
requested review from
ankitpatel96,
bogdandrutu,
boostchicken,
carsonip,
crobert-1,
dineshg13,
djaglowski,
evan-bradley,
fchikwekwe,
greatestusername,
jade-guiton-dd and
JaredTan95
|
Sorry about the review notifications folks, I was not expecting a new draft PR to add reviewers 😓 |
github-actions
bot
added
processor/cumulativetodelta
|
Bringing the PR out of draft state after getting confirmation on the approach in this comment. |
There was a problem hiding this comment.
Overall this looks okay to me, but I'd like someone more familiar with trace sampling to take a look. @kentquirk would you be willing to review this one?
|
👋 folks, the conflicts in the PR are trivial and will continue to happen with new version ups. To avoid repetitive task, I plan to fix the conflicts once the PR is approved but let me know if you want to have that fixed before reviewing - I can do that too. |
|
@kentquirk If you have a minute, could you please review this? |
| otTraceState := w3cTraceState.OTelValue() | ||
| if otTraceState == nil { | ||
| // If otel trace state is missing, default to 1 | ||
| return float64(1), nil |
There was a problem hiding this comment.
Is this defined by the sampling spec as a default value? If not we should probably error. It feels like accessing the trace state with an unset "key" is an issue.
Description
Introduces
trace_state.adjusted_countpath which calculates adjusted count for an OTTL span.Link to tracking issue
Fixes #36572
Alternative to #36573
Testing
Added unit tests
Documentation