[exporter/bmchelix] New component: BMC Helix Exporter #36964
+826
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Go init * Added README.md and code skeleton.
* Updated go version to 1.22.0 in the go.mod file.
* Fixed dependency versions in go.mod
exporter/bmchelixexporter/config.go
Outdated
| if c.ApiKey == "" { | ||
| return errors.New("api key is required") | ||
| } | ||
| if c.Timeout < 0 { |
There was a problem hiding this comment.
If timeout must be a positive integer, then I think it should be if c.Timeout <= 0
* Fixed timeout positive integer check.
fatsheep9146
approved these changes
Dec 26, 2024
songy23
added
ready to merge
bertysentry
reviewed
Dec 31, 2024
exporter/bmchelixexporter/README.md
Outdated
| - `entityTypeId`: Type identifier for the entity. | ||
| - `instanceName`: Display name of the entity. | ||
|
|
||
| > **Note:** If `entityName` or `entityTypeId` is missing, the metric will not be populated. |
There was a problem hiding this comment.
Suggested change
| > **Note:** If `entityName` or `entityTypeId` is missing, the metric will not be populated. | |
| > **Note:** If `entityName` or `entityTypeId` is missing, the metric will not be exported. | |
| To ensure the necessary attributes are not present, it is recommended to leverage the [transform processor](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/transformprocessor) with [OTTL](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/ottl), and include it in the configuration of the telemetry pipeline. | |
| The minimal pipeline most often looks like: `OTEL metrics --> (batch/memory limit) --> transform processor --> bmchelix exporter`. |
NassimBtk
commented
Jan 2, 2025
exporter/bmchelixexporter/README.md
Outdated
| - `entityTypeId`: Type identifier for the entity. | ||
| - `instanceName`: Display name of the entity. | ||
|
|
||
| > **Note:** If `entityName` or `entityTypeId` is missing, the metric will not be populated. |
* Apply suggestions from code review Co-authored-by: Bertrand Martin <[email protected]>
bertysentry
reviewed
Jan 8, 2025
exporter/bmchelixexporter/README.md
Outdated
| enabled: true | ||
| ``` | ||
|
|
||
| ### Resource to Telemetry Conversion |
There was a problem hiding this comment.
This option (resource_to_telemetry_conversion) should probably be removed as it's difficult to understand and is pretty useless in BMC Helix use case.
fatsheep9146
reviewed
Jan 8, 2025
There was a problem hiding this comment.
The go module should be updated
go: updates to go.mod needed; to update it:
go mod tidy
/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/govulncheck ./...
govulncheck: loading packages: err: exit status 1: stderr: go: updates to go.mod needed; to update it:
go mod tidy
|
Thanks a lot @fatsheep9146, I am updating the component..., I just need to adjust the configuration a bit to remove the |
…ew-component-bmc-helix-exporter
* Updated go module * Removed the resource_to_telemetry_conversion option
* Update: go.opentelemetry.io/collector/confmap v1.23.0
* Fixed ApiKey var naming (APIKey)
bertysentry
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new component for exporting metrics to BMC Helix. The changes include adding the new component to various configuration files, creating necessary documentation, and implementing the component's configuration and factory logic.
Key changes include:
New Component Addition:
.chloggen/bmchelixexporter-new-component.yaml..github/CODEOWNERSto include the new BMC Helix exporter.Documentation:
README.mdfor the BMC Helix exporter with detailed setup instructions and examples.Configuration and Factory Implementation:
config.go.config_test.go.factory.go.factory_test.go.Miscellaneous:
exporter/bmchelixexporter/Makefile.doc.go.Link to tracking issue
Fixes #36773