[jaegerreceiver] Remove unused remote sampling server #36971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Jan 7, 2025
TylerHelmuth
added
the
ready to merge
codeboten
reviewed
Jan 8, 2025
TylerHelmuth
removed
the
ready to merge
|
Looks like it still needs a |
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
force-pushed
the
jaegerreceiver-remove-sampling-endpoint
branch
from
5eb69d9 to
293cb73
Compare
|
CI failure should have been addressed with #37120, updated the branch to pull that change in |
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…#36971) #### Description The RemoteSampling config of the receiver has been disabled in the past (it just logs a warning now), but the code for the actual sampling server was still around. This PR removes that code. While the endpoint is defined in the private config https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/b53b5ad2e857367170c0ba04dfca8ad9886f0a87/receiver/jaegerreceiver/trace_receiver.go#L51 it has been removed from the public config and the private part is never populated https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/b53b5ad2e857367170c0ba04dfca8ad9886f0a87/receiver/jaegerreceiver/factory.go#L107-L109 #### Testing CI Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The RemoteSampling config of the receiver has been disabled in the past (it just logs a warning now), but the code for the actual sampling server was still around. This PR removes that code.
While the endpoint is defined in the private config
opentelemetry-collector-contrib/receiver/jaegerreceiver/trace_receiver.go
Line 51 in b53b5ad
it has been removed from the public config and the private part is never populated
opentelemetry-collector-contrib/receiver/jaegerreceiver/factory.go
Lines 107 to 109 in b53b5ad
Testing
CI