-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/tailsampling] Added debug logging to sampling decision caches #37038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
portertech
changed the title
[tailsamplingprocessor] Added debug logging to sampling decision cache
[tailsamplingprocessor] Added debug logging to sampling decision caches
Jan 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37038 +/- ##
==========================================
- Coverage 79.63% 79.63% -0.01%
==========================================
Files 2223 2223
Lines 210283 210285 +2
==========================================
- Hits 167467 167464 -3
- Misses 37206 37213 +7
+ Partials 5610 5608 -2 ☔ View full report in Codecov by Sentry. |
jpkrohling
reviewed
Jan 7, 2025
Signed-off-by: Sean Porter <[email protected]>
portertech
changed the title
[tailsamplingprocessor] Added debug logging to sampling decision caches
[processor/tailsampling] Added debug logging to sampling decision caches
Jan 7, 2025
jpkrohling
approved these changes
Jan 8, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…hes (open-telemetry#37038) #### Description This pull-request adds debug logging to the sampling decision caches, making it a little easier to debug decisions. "Trace ID is in the sampled cache" and "Trace ID is in the non-sampled cache" with the trace ID as a zap field. --------- Signed-off-by: Sean Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull-request adds debug logging to the sampling decision caches, making it a little easier to debug decisions.
"Trace ID is in the sampled cache" and "Trace ID is in the non-sampled cache" with the trace ID as a zap field.