[chore] Add replaces for new modules in core #37043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
djaglowski,
andrzej-stencel,
crobert-1,
atoulme,
dashpole,
MovieStoreGuy,
jpkrohling,
mx-psi,
songy23,
jmacd,
bogdandrutu,
TylerHelmuth and
jsuereth
as code owners
github-actions
bot
added
connector/datadog
exporter/alertmanager
exporter/alibabacloudlogservice
github-actions
bot
added
receiver/windowseventlog
testbed
exporter/kinetica
exporter/opensearch
receiver/jmx
dmitryax
force-pushed
the
overrides-for-new-modules
branch
from
b76e964 to
6c568e4
Compare
|
They can be removed after running updating the core dependency |
crobert-1
approved these changes
Jan 6, 2025
dmitryax
force-pushed
the
overrides-for-new-modules
branch
from
6c568e4 to
8d0584c
Compare
dmitryax
requested review from
fatsheep9146,
evan-bradley,
ChrsMark,
yurishkuro,
mwear and
codeboten
as code owners
dmitryax
force-pushed
the
overrides-for-new-modules
branch
2 times, most recently
from
7b36c61 to
3119dc0
Compare
dmitryax
force-pushed
the
overrides-for-new-modules
branch
from
3119dc0 to
09796c2
Compare
songy23
approved these changes
Jan 7, 2025
dmitryax
force-pushed
the
overrides-for-new-modules
branch
from
09796c2 to
71d10d9
Compare
codeboten
reviewed
Jan 7, 2025
Can be done that way as well. Not a big difference. Just seems like more back and forths |
Run the following commands: ``` make for-all CMD="go mod edit -replace go.opentelemetry.io/collector/extension/xextension=go.opentelemetry.io/collector/extension/[email protected]" make for-all CMD="go mod edit -replace go.opentelemetry.io/collector/scraper/scraperhelper=go.opentelemetry.io/collector/scraper/[email protected]" ```
dmitryax
force-pushed
the
overrides-for-new-modules
branch
from
71d10d9 to
9c25be1
Compare
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
To unblock collector core dependency update. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12639934611/job/35222671837?pr=37037 Add the replace statements to all modules that use deprecated modules by running the following commands: ``` make for-all CMD="go mod edit -replace go.opentelemetry.io/collector/extension/xextension=go.opentelemetry.io/collector/extension/[email protected]" make for-all CMD="go mod edit -replace go.opentelemetry.io/collector/scraper/scraperhelper=go.opentelemetry.io/collector/scraper/[email protected]" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock collector core dependency update. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12639934611/job/35222671837?pr=37037
Add the replace statements to all modules that use deprecated modules by running the following commands: