-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/k8sattributes] update internally stored pods with replicaset/deployment information #37088
Merged
TylerHelmuth
merged 9 commits into
open-telemetry:main
from
bacherfl:fix/37056/k8sattr-deployment-name
Jan 9, 2025
Merged
[processor/k8sattributes] update internally stored pods with replicaset/deployment information #37088
TylerHelmuth
merged 9 commits into
open-telemetry:main
from
bacherfl:fix/37056/k8sattr-deployment-name
Jan 9, 2025
+540
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
ChrsMark,
dmitryax,
fatsheep9146 and
TylerHelmuth
January 8, 2025 07:10
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
changed the title
[receiver/k8sattributes] update internally stored pods with replicaset/deployment information
[processor/k8sattributes] update internally stored pods with replicaset/deployment information
Jan 8, 2025
Signed-off-by: Florian Bacher <[email protected]>
ChrsMark
reviewed
Jan 8, 2025
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
ChrsMark
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Florian Bacher <[email protected]>
…ame' into fix/37056/k8sattr-deployment-name
TylerHelmuth
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the k8sattributes processor to update its internally stored pods with the information about their respective replica sets and deployments, after the replica set information is received via the informer.
This can happen during the initial sync of the processor, where it can happen that the replica set information for existing pods is received after the pods have already been received and stored internally.
Link to tracking issue
Fixes #37056
Testing
Added unit test
Documentation