hostmetrics: Adding process.uptime metric #37492
Open
+196
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @MovieStoreGuy, the implementation looks good. Could you adjust the metric definition to match |
MovieStoreGuy
force-pushed
the
msg/process-uptime-addition
branch
from
79a9b0b to
e90f0b5
Compare
braydonk
approved these changes
Jan 27, 2025
MovieStoreGuy
force-pushed
the
msg/process-uptime-addition
branch
from
5d4da0f to
854a2b4
Compare
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley and
mackjmr
|
Alright, I have resolved all the issues with regards to tests and linting, however, there is some vulns being reported due to the go version being used within tests. These should be fixed outside of this PR and merged in to validate the complete CI workflow. |
This adds process uptime into the hostmetrics receiver.
MovieStoreGuy
force-pushed
the
msg/process-uptime-addition
branch
from
ae13f0b to
cf81852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new metric into hostmetric process scraper to track process uptime
Link to tracking issue
Fixes #36667
Testing
Added tests to validate coverage.
Documentation
Added as part of mdatagen