Merge main into v0.103.x branch
#10433
Conversation
#10384 updated `goreleaser` to a new major version and this appears to have [broken the config](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/9565775767/job/26369463094). This problem only became apparent during the release process since the config is not used otherwise. This PR adds a github action to run `goreleaser check` on all PRs, since changes to the config may not be caught until release is attempted. I've also included what may be the only necessary change to the config, by [renaming `changelog.skip` to `changelog.disable`](goreleaser/goreleaser@29f30b6). This passes `goreleaser check` when run locally. The `monorepo` section of the config fails locally, but the feature appears to require the Pro version so I'm unclear if it will pass with the OSS version.
This PR changes the trigger for releasing the builder to match the builder module tag. This allows us to release the builder separately by pushing a dedicated tag.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,29 @@ | |||
| name: Check GoReleaser Config | |||
Check failure
Code scanning / Scorecard
Token-Permissions High
There was a problem hiding this comment.
we can ignore this alert for now, as we have other workflows that will need to be updated as well
There was a problem hiding this comment.
Agreed, the comment on #10433 (comment) also makes it seem like CodeQL is a bit confused
djaglowski
requested review from
a team and
songy23
and removed request for
a team
| @@ -0,0 +1,29 @@ | |||
| name: Check GoReleaser Config | |||
There was a problem hiding this comment.
Agreed, the comment on #10433 (comment) also makes it seem like CodeQL is a bit confused
No description provided.