Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Update contrib release step 1 #10439

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

djaglowski
Copy link
Member

When I performed this step yesterday, I found that it was necessary to update the builder configs first, otherwise make update-otel would fail. This PR just updates the order of operations to match what worked for me.

@djaglowski djaglowski added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Jun 19, 2024
@djaglowski djaglowski marked this pull request as ready for review June 19, 2024 13:44
@djaglowski djaglowski requested review from a team and songy23 June 19, 2024 13:44
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (ea7270c) to head (ed60535).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10439   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         386      386           
  Lines       18400    18400           
=======================================
  Hits        16995    16995           
  Misses       1052     1052           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mx-psi mx-psi merged commit 05a2844 into open-telemetry:main Jun 20, 2024
43 of 59 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants