Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Include component id/type in start error #11837

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rogercoll
Copy link
Contributor

@rogercoll rogercoll commented Dec 10, 2024

Description

Wraps the component ID and type into the component's start retuned error. If telemetry::logs::level is < error (e.g fatal), the service error message does not give information about which pipeline component failed:

Current error message:

 $ otelcontribcol --config config.yaml
Error: cannot start pipelines: start function error
2024/12/10 10:07:25 collector server run finished with error: cannot start pipelines: start function error

With these changes:

$ otelcontribcol --config config.yaml
Error: cannot start pipelines: failed to start geoip processor: start function error
2024/12/10 09:58:29 collector server run finished with error: cannot start pipelines: failed to start geoip processor: start function error

Link to tracking issue

#10426

Testing

Documentation

@rogercoll rogercoll requested a review from a team as a code owner December 10, 2024 09:08
@rogercoll rogercoll requested a review from dmitryax December 10, 2024 09:08
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (461a355) to head (32e5880).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11837   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         462      462           
  Lines       24886    24886           
=======================================
  Hits        22840    22840           
  Misses       1664     1664           
  Partials      382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

service/internal/graph/graph.go Outdated Show resolved Hide resolved
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants