[chore] Nit-fix exporter.request.MergeSplit() #12016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes how
capacityLimit
is updated inexporter.request.MergeSplit()
.Before
After
With that said, the original implementation does not cause any bug because "the larger for loop" loops through only two items. In the first loop,
destReq
is guaranteed to benil
, socapacityLeft
is updated properly. In the second loop, we jump out of the loop immediately so the accuracy ofcapacityLeft
does not matter any more.Link to tracking issue
NA
Testing
NA
Documentation
NA