Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][confighttp] Move MetricsLevel check to MeterProvider creation #12126

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 20, 2025

Description

Drops otelhttp metrics depending of level with a view instead of passing a noop MeterProvider

I am not sure if this would have a performance impact or not. Checked with Damien, this should not have any visible impact.

Link to tracking issue

Updates #11061

@mx-psi mx-psi force-pushed the mx-psi/drop-otelhttp-if-not-detailed branch from 795a65b to 9de9b3f Compare January 20, 2025 17:18
@mx-psi mx-psi requested a review from dmathieu January 20, 2025 17:19
@mx-psi mx-psi marked this pull request as ready for review January 20, 2025 17:27
@mx-psi mx-psi requested a review from a team as a code owner January 20, 2025 17:27
@mx-psi mx-psi requested a review from bogdandrutu January 20, 2025 17:27
@mx-psi mx-psi changed the title [chore] Move MetricsLevel check to MeterProvider creation [chore][confighttp] Move MetricsLevel check to MeterProvider creation Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (e87797c) to head (850c762).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12126      +/-   ##
==========================================
+ Coverage   91.71%   91.73%   +0.02%     
==========================================
  Files         463      463              
  Lines       24803    24830      +27     
==========================================
+ Hits        22749    22779      +30     
+ Misses       1672     1670       -2     
+ Partials      382      381       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jade-guiton-dd
Copy link
Contributor

Note: configgrpc has nearly identical code and will need to be updated similarly to remove the reference to TelemetrySettings.MetricsLevel

@mx-psi mx-psi requested a review from codeboten January 21, 2025 16:20
@bogdandrutu
Copy link
Member

@mx-psi need a rebase

@mx-psi mx-psi enabled auto-merge January 22, 2025 10:21
@mx-psi mx-psi added this pull request to the merge queue Jan 22, 2025
Merged via the queue into open-telemetry:main with commit 45a8024 Jan 22, 2025
50 of 51 checks passed
@mx-psi mx-psi deleted the mx-psi/drop-otelhttp-if-not-detailed branch January 22, 2025 10:54
@mx-psi
Copy link
Member Author

mx-psi commented Jan 22, 2025

Note: configgrpc has nearly identical code and will need to be updated similarly to remove the reference to TelemetrySettings.MetricsLevel

PTAL at #12158 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants