-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][confighttp] Move MetricsLevel check to MeterProvider creation #12126
[chore][confighttp] Move MetricsLevel check to MeterProvider creation #12126
Conversation
795a65b
to
9de9b3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12126 +/- ##
==========================================
+ Coverage 91.71% 91.73% +0.02%
==========================================
Files 463 463
Lines 24803 24830 +27
==========================================
+ Hits 22749 22779 +30
+ Misses 1672 1670 -2
+ Partials 382 381 -1 ☔ View full report in Codecov by Sentry. |
Note: |
@mx-psi need a rebase |
45a8024
PTAL at #12158 :) |
Description
Drops
otelhttp
metrics depending of level with a view instead of passing a noopMeterProvider
I am not sure if this would have a performance impact or not.Checked with Damien, this should not have any visible impact.Link to tracking issue
Updates #11061