Skip to content

Commit

Permalink
Fix behavior of opentracing-shim when added as subdirectory of a larg…
Browse files Browse the repository at this point in the history
…er project (#2356)
  • Loading branch information
andremarianiello authored Oct 11, 2023
1 parent df96b74 commit 2c4b2a9
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions opentracing-shim/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ target_include_directories(
"$<INSTALL_INTERFACE:include>")

if(OPENTRACING_DIR)
include_directories(
"${CMAKE_BINARY_DIR}/${OPENTRACING_DIR}/include"
"${CMAKE_SOURCE_DIR}/${OPENTRACING_DIR}/include"
"${CMAKE_SOURCE_DIR}/${OPENTRACING_DIR}/3rd_party/include")
target_include_directories(
${this_target}
PUBLIC
"$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/${OPENTRACING_DIR}/include>"
"$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/${OPENTRACING_DIR}/include>"
"$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/${OPENTRACING_DIR}/3rd_party/include>"
)
target_link_libraries(${this_target} opentelemetry_api opentracing)
else()
target_link_libraries(${this_target} opentelemetry_api
Expand Down

1 comment on commit 2c4b2a9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2c4b2a9 Previous: df96b74 Ratio
BM_SpanIdDefaultConstructor 4.296200354215826 ns/iter 1.6990198474799663 ns/iter 2.53

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.