Skip to content

Commit

Permalink
[BUILD] Incorrect test on ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW (#2546)
Browse files Browse the repository at this point in the history
  • Loading branch information
@marcalff
marcalff authored Feb 22, 2024
1 parent 2f3fbd4 commit 4eb99f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion exporters/otlp/src/otlp_grpc_client.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ std::shared_ptr<grpc::Channel> OtlpGrpcClient::MakeChannel(const OtlpGrpcClientO
grpc::SslCredentialsOptions ssl_opts;
ssl_opts.pem_root_certs = GetFileContentsOrInMemoryContents(
options.ssl_credentials_cacert_path, options.ssl_credentials_cacert_as_string);
#if ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW
#ifdef ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW
ssl_opts.pem_private_key = GetFileContentsOrInMemoryContents(options.ssl_client_key_path,
options.ssl_client_key_string);
ssl_opts.pem_cert_chain = GetFileContentsOrInMemoryContents(options.ssl_client_cert_path,
Expand Down

2 comments on commit 4eb99f9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 4eb99f9 Previous: 2f3fbd4 Ratio
BM_BaselineBuffer/2 15307321.548461914 ns/iter 2795631.8855285645 ns/iter 5.48
BM_BaselineBuffer/4 14560928.344726562 ns/iter 2565044.4910230828 ns/iter 5.68
BM_LockFreeBuffer/2 10259521.007537842 ns/iter 973639.2498016357 ns/iter 10.54
BM_LockFreeBuffer/4 10139889.71710205 ns/iter 1023565.7679634193 ns/iter 9.91

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 4eb99f9 Previous: 2f3fbd4 Ratio
BM_ProcYieldSpinLockThrashing/1/process_time/real_time 0.21403634018655202 ms/iter 0.08435423781232136 ms/iter 2.54

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.