Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with clang 19 #3055

Closed
wants to merge 3 commits into from
Closed

Conversation

osokin
Copy link

@osokin osokin commented Sep 8, 2024

Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281359 for details.

Credit: Dimitry Andric [email protected]

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@osokin osokin requested a review from a team September 8, 2024 21:16
Copy link

linux-foundation-easycla bot commented Sep 8, 2024

CLA Not Signed

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Sep 8, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

LGTM once CLA is signed.

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (497eaf4) to head (4c94c31).
Report is 133 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
+ Coverage   87.12%   87.79%   +0.68%     
==========================================
  Files         200      195       -5     
  Lines        6109     5953     -156     
==========================================
- Hits         5322     5226      -96     
+ Misses        787      727      -60     
Files with missing lines Coverage Δ
api/include/opentelemetry/logs/event_logger.h 90.91% <100.00%> (-1.39%) ⬇️
api/include/opentelemetry/logs/logger.h 63.89% <100.00%> (-0.69%) ⬇️
...pi/include/opentelemetry/logs/logger_type_traits.h 100.00% <100.00%> (+16.00%) ⬆️

... and 123 files with indirect coverage changes

@osokin
Copy link
Author

osokin commented Sep 8, 2024

Thanks for the fix.

LGTM once CLA is signed.

Signing the CLA requests mailing address, don't think I want to share it until I get details about CRUD for such data.

@lalitb
Copy link
Member

lalitb commented Sep 9, 2024

Signing the CLA requests mailing address, don't think I want to share it until I get details about CRUD for such data.

As you're signing the CLA for CNCF, which is part of the Linux Foundation, the collection and use of the email is governed by the Linux Foundation's privacy policy. You can review the details of their policy here: https://www.linuxfoundation.org/legal/privacy-policy.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CLA is signed.

@osokin
Copy link
Author

osokin commented Sep 9, 2024

Signing the CLA requests mailing address, don't think I want to share it until I get details about CRUD for such data.

As you're signing the CLA for CNCF, which is part of the Linux Foundation, the collection and use of the email is governed by the Linux Foundation's privacy policy. You can review the details of their policy here: https://www.linuxfoundation.org/legal/privacy-policy.

Thanks, I'll take a look, that may take some time.

@marcalff
Copy link
Member

/easycla

@marcalff marcalff requested a review from a team as a code owner September 23, 2024 06:50
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 4c94c31
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/66f10fa873d1dd000841fa69

@marcalff
Copy link
Member

/easycla

@marcalff
Copy link
Member

marcalff commented Oct 2, 2024

Hi @osokin, have you made a decision regarding the Linux Foundation Contributor License Agreement (CLA) ?

Please indicate if this PR should be kept opened (to allow time to process the CLA), or if it should be closed.

Thanks.

@osokin
Copy link
Author

osokin commented Oct 3, 2024

Hi @osokin, have you made a decision regarding the Linux Foundation Contributor License Agreement (CLA) ?

Please indicate if this PR should be kept opened (to allow time to process the CLA), or if it should be closed.

Thanks.

I decided not to sharing my mail address, sorry about that.

@marcalff
Copy link
Member

marcalff commented Oct 3, 2024

Thanks for the update.

Closing this PR then.

@marcalff marcalff closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:waiting-on-cla Waiting on CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants