-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with clang 19 #3055
Fix build with clang 19 #3055
Conversation
Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281359 for details. Credit: Dimitry Andric <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
LGTM once CLA is signed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3055 +/- ##
==========================================
+ Coverage 87.12% 87.79% +0.68%
==========================================
Files 200 195 -5
Lines 6109 5953 -156
==========================================
- Hits 5322 5226 -96
+ Misses 787 727 -60
|
Signing the CLA requests mailing address, don't think I want to share it until I get details about CRUD for such data. |
As you're signing the CLA for CNCF, which is part of the Linux Foundation, the collection and use of the email is governed by the Linux Foundation's privacy policy. You can review the details of their policy here: https://www.linuxfoundation.org/legal/privacy-policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CLA is signed.
Thanks, I'll take a look, that may take some time. |
/easycla |
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
/easycla |
Hi @osokin, have you made a decision regarding the Linux Foundation Contributor License Agreement (CLA) ? Please indicate if this PR should be kept opened (to allow time to process the CLA), or if it should be closed. Thanks. |
I decided not to sharing my mail address, sorry about that. |
Thanks for the update. Closing this PR then. |
Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281359 for details.
Credit: Dimitry Andric [email protected]
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes