Update note on SqlClient #2424
Open
Update note on SqlClient #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
github-actions
bot
added
comp:instrumentation.sqlclient
Kielek
approved these changes
Dec 17, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287
Design discussion issue #
Changes
Updated the note for the SqlClient instrumentation to (hopefully) make it easier to see that you need to use the
Microsoft.Data.SqlClientpackage to get info out.Relates to #2287 as I think both the reporter and me (for a while) missed that the note implied that you can't really use the
System.Data.SqlClientpackage.I've run markdownlint with no issues which I think is all that's needed for this PR but please lmk if there's anything else.
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)