[RabbitMQ] derived instrumentations for base consumer types #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RassK
approved these changes
Aug 7, 2024
pjanotti
approved these changes
Aug 7, 2024
nrcventura
approved these changes
Aug 7, 2024
...trumentation/Instrumentations/RabbitMq6/Integrations/AsyncDefaultBasicConsumerIntegration.cs
Show resolved
Hide resolved
...toInstrumentation/Instrumentations/RabbitMq6/Integrations/DefaultBasicConsumerIntegration.cs
Show resolved
Hide resolved
zacharycmontoya
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #3392
Followup for #3533
What
Extends the coverage of instrumented consumer types to types deriving from base consumer types from the library:
DefaultBasicConsumerandAsyncDefaultBasicConsumer.Derived instrumentations were already supported by the profiler, but not used until now.
InstrumentationDefinitionsGeneratorwas modified to produce the list of derived instrumentations.@zacharycmontoya PTAL
Tests
Included in CI.
Checklist
- [ ]CHANGELOG.mdis updated.- [ ] Documentation is updated.