Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tesla): removing warnings and clean up test cases #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(tesla): removing warnings and clean up test cases #409

wants to merge 1 commit into from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Nov 6, 2024 •
edited
Loading

Context

Doing some grunt work, removing the warning from the test environment and clean up other things around the test cases

..     warning: redefining module Tesla.Middleware.OpenTelemetryTest.TestClient (current version defined in memory)
     │
 227 │       defmodule TestClient do
     │       ~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ test/middleware/opentelemetry_tesla_middleware_test.exs:227: Tesla.Middleware.OpenTelemetryTest.TestClient (module)

.     warning: redefining module Tesla.Middleware.OpenTelemetryTest.TestClient (current version defined in memory)
     │
 227 │       defmodule TestClient do
     │       ~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ test/middleware/opentelemetry_tesla_middleware_test.exs:227: Tesla.Middleware.OpenTelemetryTest.TestClient (module)

.     warning: redefining module Tesla.Middleware.OpenTelemetryTest.TestClient (current version defined in memory)
     │
 227 │       defmodule TestClient do
     │       ~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ test/middleware/opentelemetry_tesla_middleware_test.exs:227: Tesla.Middleware.OpenTelemetryTest.TestClient (module)

.     warning: redefining module Tesla.Middleware.OpenTelemetryTest.TestClient (current version defined in memory)
     │
 227 │       defmodule TestClient do
     │       ~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ test/middleware/opentelemetry_tesla_middleware_test.exs:227: Tesla.Middleware.OpenTelemetryTest.TestClient (module)

.     warning: redefining module Tesla.Middleware.OpenTelemetryTest.TestClient (current version defined in memory)
     │
 227 │       defmodule TestClient do
     │       ~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ test/middleware/opentelemetry_tesla_middleware_test.exs:227: Tesla.Middleware.OpenTelemetryTest.TestClient (module)

.    warning: redefining module Tesla.Middleware.OpenTelemetryTest.TestClient (current version defined in memory)
    │
 98 │       defmodule TestClient do
    │       ~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ test/middleware/opentelemetry_tesla_middleware_test.exs:98: Tesla.Middleware.OpenTelemetryTest.TestClient (module)

@yordis yordis marked this pull request as ready for review November 6, 2024 20:47
@yordis
Copy link
Contributor Author

yordis commented Dec 6, 2024

@bryannaegele is it possible to review this one?

btkostner
btkostner approved these changes Dec 26, 2024
View reviewed changes
Copy link

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sane cleanup and much easier to read without all of the defmodules in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btkostner btkostner btkostner approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
elixir instrumentation opentelemetry_tesla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yordis @btkostner