fix(otelgin): do not override spanname if empty

open-telemetry · Oct 14, 2024 · 6403414 · 6403414
1 parent f3da1c6
commit 6403414
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/instrumentation/github.com/gin-gonic/gin/otelgin/gintrace.go b/instrumentation/github.com/gin-gonic/gin/otelgin/gintrace.go
@@ -136,9 +136,7 @@ func Middleware(service string, opts ...Option) gin.HandlerFunc {
 		if spanName == "" {
 			spanName = fmt.Sprintf("HTTP %s route not found", c.Request.Method)
 		} else {
-			rAttr := semconv.HTTPRoute(spanName)
-			opts = append(opts, oteltrace.WithAttributes(rAttr))
-			metricAttrs = append(metricAttrs, rAttr)
+			metricAttrs = append(metricAttrs, semconv.HTTPRoute(spanName))
 		}
 		ctx, span := tracer.Start(ctx, spanName, opts...)
 		defer span.End()