Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting per-request custom metrics in gRPC stats handler. #6092

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into grpc-per-rpc-metric-attributes

b474ced
Select commit
Loading
Failed to load commit list.
Draft

Allow setting per-request custom metrics in gRPC stats handler. #6092

Merge branch 'main' into grpc-per-rpc-metric-attributes
b474ced
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 6, 2024 in 1s

0.0% of diff hit (target 65.7%)

View this Pull Request on Codecov

0.0% of diff hit (target 65.7%)

Annotations

Check warning on line 298 in instrumentation/google.golang.org/grpc/otelgrpc/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/config.go#L296-L298 

Added lines #L296 - L298 were not covered by tests

Check warning on line 305 in instrumentation/google.golang.org/grpc/otelgrpc/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/config.go#L304-L305 

Added lines #L304 - L305 were not covered by tests

Check warning on line 156 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L156 

Added line #L156 was not covered by tests

Check warning on line 159 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L159 

Added line #L159 was not covered by tests

Check warning on line 162 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L162 

Added line #L162 was not covered by tests
View more details on Codecov