Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gosec lint issues #6107

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix gosec lint issues #6107

merged 1 commit into from
Sep 11, 2024

Conversation

dmathieu
Copy link
Member

This fixes the new lint issues so #6101 can upgrade golangci-lint.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 11, 2024
@dmathieu dmathieu marked this pull request as ready for review September 11, 2024 12:25
@dmathieu dmathieu requested a review from a team September 11, 2024 12:25
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.7%. Comparing base (774b20e) to head (c381e51).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lang.org/grpc/otelgrpc/internal/test/test_utils.go 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6107   +/-   ##
=====================================
  Coverage   65.7%   65.7%           
=====================================
  Files        203     203           
  Lines      13039   13039           
=====================================
  Hits        8570    8570           
  Misses      4206    4206           
  Partials     263     263           
Files with missing lines Coverage Δ
...lang.org/grpc/otelgrpc/internal/test/test_utils.go 50.0% <0.0%> (ø)

@dashpole dashpole merged commit 5425de9 into open-telemetry:main Sep 11, 2024
27 of 29 checks passed
@dmathieu dmathieu deleted the fix-lint branch October 10, 2024 08:32
@MrAlias MrAlias added this to the v1.30.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants