Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add tests for socket endpoint #6636

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

dmathieu
Copy link
Member

This adds tests in the config package ensuring socket endpoints are properly supported.
See open-telemetry/opentelemetry-collector#11941 and open-telemetry/opentelemetry-collector#12059

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.7%. Comparing base (9a53a30) to head (b1a8d09).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6636   +/-   ##
=====================================
  Coverage   68.7%   68.7%           
=====================================
  Files        200     200           
  Lines      16872   16872           
=====================================
+ Hits       11601   11604    +3     
+ Misses      4927    4925    -2     
+ Partials     344     343    -1     

see 1 file with indirect coverage changes

@dmathieu dmathieu merged commit 4e900d0 into open-telemetry:main Jan 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants