Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to semconv for otelmux #6638 #6648

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinyonatann
Copy link

Address issue #6638

@martinyonatann martinyonatann requested a review from a team as a code owner January 19, 2025 18:39
Copy link

linux-foundation-easycla bot commented Jan 19, 2025

CLA Signed

  • ✅login: martinyonatann / (a82a7eb)

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from akats7 January 19, 2025 18:39
@dmathieu
Copy link
Member

Thank you for this! ❤️

This PR does a lot more than just setup semconv.
In order to allow for better reviews, could you split it into multiple PRs?
From a first look, I'd do at least four:

  • Setup the body wrapper and use it.
  • Change the default span name behavior.
  • Introduce the semconv package, and use it with tracing only.
  • Introduce metrics support.

Striving for atomic PRs (each PR changes a single thing) makes for much speeder reviews.

@martinyonatann
Copy link
Author

martinyonatann commented Jan 20, 2025

thankyou for the feedback @dmathieu ! ❤️
You're absolutely right, this PR ended up covering more ground than initially intended. i appreciate your suggestion to split it into atomic PRs for easier review. i'll get started on breaking it down into the following :

This approach should make the review process smother and more efficient. i'll prioritize reorganizing these changes and will submit the individual PRs soon. Let me know if there are any additional points you'd like me to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants