add example for OTLP logging via stdout and k8s #547
Merged
+495
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrille-leclerc
suggested changes
Dec 18, 2024
logging-k8s-stdout-otlp-json/otel-collector-otlpjson-pipeline.png
Outdated
Show resolved
Hide resolved
logging-k8s-stdout-otlp-json/otel-collector-otlpjson-pipeline.png
Outdated
Show resolved
Hide resolved
cyrille-leclerc
approved these changes
Dec 18, 2024
|
@trask can you take a look? |
trask
reviewed
Dec 20, 2024
| exporters: [ otlphttp/metrics ] | ||
| logs/raw_otlpjson: | ||
| receivers: [ filelog/otlp-json-logs ] | ||
| # (i) no need for processors before the otlpjson connector |
| # renovate: datasource=github-releases depName=opentelemetry-java-instrumentation packageName=open-telemetry/opentelemetry-java-instrumentation | ||
| ENV OPENTELEMETRY_JAVA_INSTRUMENTATION_VERSION=v2.10.0 | ||
|
|
||
| ADD build/libs/*SNAPSHOT.jar ./app.jar |
There was a problem hiding this comment.
what do you think about adding the ../gradlew assemble here, and then I think could remove it from (the global) run-acceptance-tests.sh file?
There was a problem hiding this comment.
you'd need to copy the source files and gradle wrapper to do that - quite hard to understand
In detail: You need to copy all projects - or manipulate settings.gradle.kts to only include the one project we need
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
|
@trask please check again |
trask
approved these changes
Jan 8, 2025
.github/workflows/oats-tests.yml
Outdated
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: grafana/oats | ||
| ref: bc2f08c5e55114234cece216290f1580a75a6032 |
There was a problem hiding this comment.
is there a version tag that we can use instead? or are you using ref for more security. in which case let's put version tag in comment e.g.
Suggested change
| ref: bc2f08c5e55114234cece216290f1580a75a6032 | |
| ref: bc2f08c5e55114234cece216290f1580a75a6032 # v0.1.0 |
|
@trask please check again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates open-telemetry/opentelemetry.io#5754