Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-sdk): SQS receive: use span links instead of processing spans #2345

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Jul 18, 2024

Which problem is this PR solving?

Drop SQS processing spans in favor of span links as per latest specification.

Fixes #707

Short description of the changes

Create a span link for each incoming message that has a propagation context.

@seemk seemk changed the title feat(aws-sdk): use span links instead of processing spans feat(aws-sdk): SQS receive: use span links instead of processing spans Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (0309cae) to head (f237133).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
- Coverage   90.77%   90.77%   -0.01%     
==========================================
  Files         169      169              
  Lines        8015     8011       -4     
  Branches     1632     1630       -2     
==========================================
- Hits         7276     7272       -4     
  Misses        739      739              
Files with missing lines Coverage Δ
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (ø)

@seemk seemk requested a review from a team as a code owner September 25, 2024 04:14
@seemk
Copy link
Contributor Author

seemk commented Nov 6, 2024

@jj22ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion(instrumentation-aws-sdk): SQS receive according to semantic conventions
2 participants