feat: Add page view instrumentation plugin #2386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abinet18
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 156 156
Lines 7728 7728
Branches 1590 1590
=======================================
Hits 7013 7013
Misses 715 715 |
martinkuba
requested changes
Aug 27, 2024
plugins/web/opentelemetry-instrumentation-page-view/package.json
Outdated
Show resolved
Hide resolved
plugins/web/opentelemetry-instrumentation-page-view/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
Abinet18
force-pushed
the
feat/add-page-view-instrumentation
branch
from
57ab371
to
3c980fa
Compare
martinkuba
reviewed
Sep 17, 2024
plugins/web/opentelemetry-instrumentation-page-view/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…mentation.ts Co-authored-by: Martin Kuba <[email protected]>
Abinet18
force-pushed
the
feat/add-page-view-instrumentation
branch
from
bee412c
to
e204c33
Compare
martinkuba
approved these changes
Oct 15, 2024
|
@Abinet18 I have approved the PR, but forgot to mention that also these files should be updated:
|
scheler
approved these changes
Oct 17, 2024
|
@martinkuba , when can this be merged. I would fix the conflict just before the merge time so that I don't have to do it every time the main branch changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the client sdk project, Implement PageView event instrumentation
#2372
This PR adds the page view instrumentation which sends an event when a page is loaded (as soon as the html is loaded) or when a route change happens (tracking the history push and replace states)
Tested on an example app with generic routes that use the history api