Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples/web): updated webpack deps and npm start #2530

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

xonev
Copy link
Contributor

@xonev xonev commented Nov 16, 2024

Fixes an issue where webpack and webpack-cli versions were incompatible.

Part of #2528

Which problem is this PR solving?

Making the web example build and run again (#2528)

Prior to this change, I'd get errors like the following with npm install:

npm install                                                                                                                          main :: 7d :: ⬢
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"5.89.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"4.x.x" from [email protected]
npm ERR! node_modules/webpack-cli
npm ERR!   dev webpack-cli@"^3.3.12" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Short description of the changes

  • I updated webpack-cli and webpack-dev-server. This required some updates to the arguments used to

Fixes an issue where webpack and webpack-cli versions were incompatible.
@xonev xonev requested a review from a team as a code owner November 16, 2024 00:04
Copy link

linux-foundation-easycla bot commented Nov 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xonev / name: Steven Oxley (9a9fa52, bd4c49a)
  • ✅ login: pichlermarc / name: Marc Pichler (1e4b81d)

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (2784357) to head (1e4b81d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2530   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it works now, thanks for taking care of this 🙌

@trentm trentm changed the title fix(examples): updated webpack deps and npm start. fix(examples/web): updated webpack deps and npm start Nov 26, 2024
@trentm trentm merged commit 6ee7e7f into open-telemetry:main Nov 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants