Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-sdk): migrate SEMATTRS_* to ATTR_* #2550

Closed

fix(aws-sdk): reintroduce `SEMATTRS_*` which were changed

6333ee3
Select commit
Loading
Failed to load commit list.
Closed

chore(aws-sdk): migrate SEMATTRS_* to ATTR_* #2550

fix(aws-sdk): reintroduce `SEMATTRS_*` which were changed
6333ee3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 1s

90.81% (+0.05%) compared to 2784357

View this Pull Request on Codecov

90.81% (+0.05%) compared to 2784357

Details

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.81%. Comparing base (2784357) to head (6333ee3).

Files with missing lines Patch % Lines
...try-instrumentation-aws-sdk/src/services/lambda.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2550      +/-   ##
==========================================
+ Coverage   90.75%   90.81%   +0.05%     
==========================================
  Files         169      169              
  Lines        8018     8021       +3     
  Branches     1632     1632              
==========================================
+ Hits         7277     7284       +7     
+ Misses        741      737       -4     
Files with missing lines Coverage Δ
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 95.06% <100.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 94.28% <100.00%> (+0.16%) ⬆️
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <ø> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.87% <66.66%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes