Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-mysql2): Add hook for setting span name #2555

Closed

Conversation

Just-Sieb
Copy link
Contributor

Which problem is this PR solving?

My company runs a set clause to set a connection SQL variables to the user triggering the action before all our SQL clauses. This means the span name for requests always ends up being set which is not useful. Plus now that WITH statements are a more common SQL feature I am sure plenty of users could benefit from a way to customize the span name.

Short description of the changes

This adds a new config option the the mysql2 instrumentation which allows people to provide custom behavior for span name. I modeled the API after the similar API that already exists in the express instrumentation.

@Just-Sieb Just-Sieb requested a review from a team as a code owner November 26, 2024 16:38
@github-actions github-actions bot added pkg:instrumentation-mysql2 pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (d5215f3) to head (ad48e45).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2555      +/-   ##
==========================================
+ Coverage   90.80%   97.60%   +6.80%     
==========================================
  Files         169        9     -160     
  Lines        8018      502    -7516     
  Branches     1632       90    -1542     
==========================================
- Hits         7281      490    -6791     
+ Misses        737       12     -725     

see 160 files with indirect coverage changes

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Copy link
Contributor

This issue was closed because no owner or sponsor has been found after 14 days

@github-actions github-actions bot closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:instrumentation-mysql2 pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant