feat(instrumentation-mysql2): Add hook for setting span name #2555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
My company runs a set clause to set a connection SQL variables to the user triggering the action before all our SQL clauses. This means the span name for requests always ends up being set which is not useful. Plus now that WITH statements are a more common SQL feature I am sure plenty of users could benefit from a way to customize the span name.
Short description of the changes
This adds a new config option the the mysql2 instrumentation which allows people to provide custom behavior for span name. I modeled the API after the similar API that already exists in the express instrumentation.