Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run browser tests on Node.js 22 #2587

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Some devDependencies for browser/webworker tests require Node.js 18+. Since Node.js Version for web tests only affects development, we can bump the version we use for testing browser/workers to Node.js 22. This will unblock some Renovate updates.

How Has This Been Tested?

  • Unit tests

@pichlermarc pichlermarc requested a review from a team as a code owner December 5, 2024 16:19
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (5d60689) to head (bf492ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2587   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files         169      169           
  Lines        8026     8026           
  Branches     1635     1635           
=======================================
  Hits         7288     7288           
  Misses        738      738           

@pichlermarc pichlermarc merged commit baccd98 into open-telemetry:main Dec 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants