Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-utils): Don't swallow assertion errors from checkResult and checkCollector #2588

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

onurtemizkan
Copy link
Contributor

@onurtemizkan onurtemizkan commented Dec 5, 2024

Which problem is this PR solving?

  • Assertion errors thrown inside runTextFixture are swallowed and not reported.

Short description of the changes

  • Reject the runTestFixture promise with the thrown error, if there is one.
  • Updated Hapi tests that seem to be silently failing before this update.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (baccd98) to head (adef664).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2588      +/-   ##
==========================================
- Coverage   90.80%   90.75%   -0.05%     
==========================================
  Files         169      169              
  Lines        8026     8026              
  Branches     1635     1635              
==========================================
- Hits         7288     7284       -4     
- Misses        738      742       +4     

see 1 file with indirect coverage changes

@github-actions github-actions bot added pkg:instrumentation-hapi pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Dec 5, 2024
@onurtemizkan onurtemizkan marked this pull request as ready for review December 5, 2024 23:34
@onurtemizkan onurtemizkan requested a review from a team as a code owner December 5, 2024 23:34
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks 👍

@pichlermarc pichlermarc merged commit de679ad into open-telemetry:main Dec 6, 2024
25 checks passed
@dyladan dyladan mentioned this pull request Dec 6, 2024
@onurtemizkan onurtemizkan deleted the testfixtures-throw branch December 6, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment