-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test-utils): Don't swallow assertion errors from checkResult
and checkCollector
#2588
fix(test-utils): Don't swallow assertion errors from checkResult
and checkCollector
#2588
Conversation
…d `checkCollector`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
- Coverage 90.80% 90.75% -0.05%
==========================================
Files 169 169
Lines 8026 8026
Branches 1635 1635
==========================================
- Hits 7288 7284 -4
- Misses 738 742 +4 |
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks 👍
Which problem is this PR solving?
runTextFixture
are swallowed and not reported.Short description of the changes
runTestFixture
promise with the thrown error, if there is one.