Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-sdk)!: drop support for AWS SDK for JavaScript v2 #2623

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 6, 2025

Which problem is this PR solving?

Short description of the changes

  • Drops support for AWS SDK for JavaScript v2

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (6b4e532) to head (a1e15a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
- Coverage   90.79%   89.12%   -1.68%     
==========================================
  Files         169      169              
  Lines        8061     7970      -91     
  Branches     1646     1622      -24     
==========================================
- Hits         7319     7103     -216     
- Misses        742      867     +125     
Files with missing lines Coverage Δ
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 93.12% <ø> (-1.94%) ⬇️
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 93.10% <ø> (-4.20%) ⬇️

... and 4 files with indirect coverage changes

@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from 43d7ee6 to 07d9c02 Compare January 7, 2025 17:50
@trivikr

This comment was marked as outdated.

@trivikr trivikr changed the title chore(aws-sdk): drop support for AWS SDK for JavaScript v2 feat(aws-sdk): drop support for AWS SDK for JavaScript v2 Jan 7, 2025
@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from 1e7dd92 to fd36945 Compare January 8, 2025 20:43
@trivikr

This comment was marked as outdated.

@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from fd36945 to 74259dc Compare January 9, 2025 19:12
@pichlermarc pichlermarc changed the title feat(aws-sdk): drop support for AWS SDK for JavaScript v2 feat(aws-sdk)!: drop support for AWS SDK for JavaScript v2 Jan 15, 2025
@pichlermarc
Copy link
Member

@trivikr I changed the title to include a ! to mark this PR as a breaking change so it shows up as such in the changelog.

Please update the branch if you find the time to see if the build failures have been resolved. I think the TAV failures are resolved by #2628 and #2643 🙂

@trivikr trivikr force-pushed the deprecate-js-sdk-v2 branch from 74259dc to 293aec2 Compare January 15, 2025 16:32
@trivikr
Copy link
Contributor Author

trivikr commented Jan 15, 2025

Thank you @pichlermarc. I've rebased the changes.


The CI is failing though for the path which isn't updated

  1) MessageAttributes
       injectPropagationContext
         should inject context if there are available attributes:
     Error: expect(received).toBeGreaterThan(expected)

Test code which fails:

expect(Object.keys(contextAttributes).length).toBeGreaterThan(5);

Execution https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/12792793464/job/35664659517?pr=2623

I confirmed when debugging that propagation.inject is called but it has not impact on the contents of attributes
Source code

propagation.inject(context.active(), attributes, contextSetter);

@blumamir @jj22ee Do you know what may be going wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[instrumentation-aws-sdk] Drop support for JS SDK v2
4 participants