-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry-instrumentation-xhr): optionally ignore network events #4571
Merged
pichlermarc
merged 1 commit into
open-telemetry:main
from
MustafaHaddara:mhaddara/add-ignoreNetworkEvents-xhr
Mar 28, 2024
Merged
feat(opentelemetry-instrumentation-xhr): optionally ignore network events #4571
pichlermarc
merged 1 commit into
open-telemetry:main
from
MustafaHaddara:mhaddara/add-ignoreNetworkEvents-xhr
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MustafaHaddara
force-pushed
the
mhaddara/add-ignoreNetworkEvents-xhr
branch
from
March 21, 2024 19:46
e0c6e5d
to
9af69ae
Compare
MustafaHaddara
force-pushed
the
mhaddara/add-ignoreNetworkEvents-xhr
branch
from
March 25, 2024 19:58
9af69ae
to
9fce974
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4571 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 328 328
Lines 9494 9496 +2
Branches 2040 2042 +2
=======================================
+ Hits 8815 8817 +2
Misses 679 679
|
mjayaram
approved these changes
Mar 26, 2024
JamieDanielson
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this!
MSNev
approved these changes
Mar 27, 2024
This was referenced May 28, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
PR #3028 added a
ignoreNetworkEvents
boolean to theexperimental/opentelemetry-instrumentation-fetch
package. This PR adds the same behaviour + flag to theexperimental/opentelemetry-instrumentation-xml-http-request
package.Quoting from that PR
Short description of the changes
This PR adds an optional boolean flag
ignoreNetworkEvents
to the XMLHttpRequest instrumentation. When set to true network events are not added to the span.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running npm run test:browser will run the newly added test as part of the suite:
Checklist: