-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move xray propagator from contrib (selective history) #4599
Closed
martinkuba
wants to merge
14
commits into
open-telemetry:main
from
martinkuba:move-xray-propagator-2
Closed
Move xray propagator from contrib (selective history) #4599
martinkuba
wants to merge
14
commits into
open-telemetry:main
from
martinkuba:move-xray-propagator-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add xray propagator * chore: cleanups * Remove AWS Distro link Co-authored-by: Valentin Marchaud <[email protected]>
… fashion (open-telemetry#1328) * Extract X-Ray header in a case-insensitive fashion * Back to apostrophes * Switch to 1 tab = 2 spaces * Add semis * Apply prettier to tests as well * chore: fix lint --------- Co-authored-by: Amir Blum <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
…elemetry-js-contrib
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4599 +/- ##
==========================================
+ Coverage 92.85% 92.87% +0.02%
==========================================
Files 328 329 +1
Lines 9499 9604 +105
Branches 2042 2070 +28
==========================================
+ Hits 8820 8920 +100
- Misses 679 684 +5
|
3 tasks
Closing in favor of #4603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #4544. It brings in only two commits from contrib that specifically added/updated the propagator-aws-xray package.
part of #4494
It should be possible to configure the
xray
propagator using theOTEL_PROPAGATORS
env variable. This is currently documented here, and it is also part of the lambda spec.