Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xray propagator from contrib (selective history) #4599

Closed

Conversation

martinkuba
Copy link
Contributor

This is an alternative to #4544. It brings in only two commits from contrib that specifically added/updated the propagator-aws-xray package.


part of #4494

It should be possible to configure the xray propagator using the OTEL_PROPAGATORS env variable. This is currently documented here, and it is also part of the lambda spec.

Anuraag Agrawal and others added 7 commits March 31, 2024 20:47
* feat: add xray propagator

* chore: cleanups

* Remove AWS Distro link

Co-authored-by: Valentin Marchaud <[email protected]>
… fashion (open-telemetry#1328)

* Extract X-Ray header in a case-insensitive fashion

* Back to apostrophes

* Switch to 1 tab = 2 spaces

* Add semis

* Apply prettier to tests as well

* chore: fix lint

---------

Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Daniel Dyla <[email protected]>
@martinkuba martinkuba requested a review from a team April 2, 2024 03:29
Copy link

linux-foundation-easycla bot commented Apr 2, 2024

CLA Missing ID CLA Not Signed

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #4599 (9627194) into main (f3aedb7) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4599      +/-   ##
==========================================
+ Coverage   92.85%   92.87%   +0.02%     
==========================================
  Files         328      329       +1     
  Lines        9499     9604     +105     
  Branches     2042     2070      +28     
==========================================
+ Hits         8820     8920     +100     
- Misses        679      684       +5     
Files Coverage Δ
...kages/propagator-aws-xray/src/AWSXRayPropagator.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@pichlermarc pichlermarc mentioned this pull request Apr 2, 2024
3 tasks
@martinkuba
Copy link
Contributor Author

Closing in favor of #4603

@martinkuba martinkuba closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants